[Greatis]

Let me know if you need my help.
I have the latest Windows 11 (22000) on a virtual machine.

[Greatis]

Hi,

Seems like the problems were fixed after 2 weeks of monitoring after releasing the new version.
The problem was in this code:
SkinManager->Active=RestoreCurSkin();
I supposed if the property was set it will not executes something.
I found that it is just true.
The function SetActive checks for current setting.
procedure TsSkinManager.SetActive(const Value: boolean);
begin
if FActive <> Value then begin
FActive := Value;

But at the end of function it executes always:
SkinListController.SendSkinChanged;

Usually, it may not a problem, but my program executes this code in Timer a lot of times.

Hope it will help someone.

Thanks for help.
Resolved.

[Greatis]

Thank you for your answer!
I thought that it was my component.
But recently I saw the exception and the buttons (sButBtn) were not displayed.

I suppose you are right, the problem is in drawing buttons.

I added try/catch to avoid exception:
DrawData.SkinIndex := SkinData.SkinIndex;
try
if (DrawData.CurrentState = 0) and
(SkinData.FOwnerControl.Parent <> nil) and
(SkinData.SkinManager <> nil) and SkinData.SkinManager.IsValidSkinIndex(SkinData.SkinIndex) and
(SkinData.CommonSkinData.gd[SkinData.SkinIndex].Props[0].Transparency = 100) then
DrawData.SkinIndex := GetFontIndex(Button, SkinData.SkinIndex, SkinData.SkinManager);
except
end;

It works, but there are a lot of codes with direct access to gd.
SkinData.CommonSkinData.gd[…].

I guess that IsValidSkinIndex works well, but gd is not properly filled at the moment when we access it.
Getting this causes the exception:
Props[0].Transparency

Is there a workaround?
How to be sure that the structures are filled well before opening a window with buttons?

[Greatis]

I have my own grid component.
I use SkinManager in the main form.
My grid is declared in Thridparty list as “Grid”.

The grid component stored in a separate form.
SkinProvider exists in each form.

I see the exception immediately after showing the child form.
The form is created manually.

[Greatis]

Hi,

I understand, but I can’t do it, because is hard in reproducing.
I see it several times on my PC and I see it every day in the user’s bug reports.
I checked the latest version 15.12.
The code was not changed: sThirdParty.pas
Now the line is 460.
if (DrawData.CurrentState = 0) and
(SkinData.FOwnerControl.Parent <> nil) and
(SkinData.SkinManager <> nil) and SkinData.SkinManager.IsValidSkinIndex(SkinData.SkinIndex) and
(SkinData.CommonSkinData.gd[SkinData.SkinIndex].Props[0].Transparency = 100) then

The exception is on the:
SkinData.CommonSkinData.gd[SkinData.SkinIndex].Props[0].Transparency

I suppose that this code is not safe.
SkinData received as parameter:
procedure GetCommonData(SkinData: TsCtrlSkinData);

SkinIndex maybe wrong or gd is not properly initialized.

I want to fix the bug and asked your opinion.
What is SkinData.SkinIndex?
How to check that it is valid?
How to check that it is not bigger than the size of “gd”?

I can add “try/catch” on, but I don’t know how safe is assigning this on exception:
DrawData.SkinIndex := SkinData.SkinIndex;

Thank you!
Dmitry

[Author]

Posts