[HeDiBo]

'HeDiBo' wrote:

What seems to be the problem?

Can I be of assistance? More than willing to have a look at it.

[HeDiBo]

'Support' wrote:

I have made a big attempt for support of Lazarus, but some things exists where I'm stopped.

What seems to be the problem?

[HeDiBo]

'Support' wrote:

Hello!

Standard scrollbars are replaced by TsScrollbar control when TWebBrowser is skinned

Scrollbars which are drawn in document are hidden.

I know. But I suggested not to hide the scrollbars in the document, but replace them with properly skinned ones.

[HeDiBo]

'mol' wrote:

AFAIK, Firefox and Chrome do not allow user-defined painting of scrollbars, but there are other ways such as WebKit CSS to achieve this. IE is important though because the TWebBrowser component is based on it.

In that case, there's yet another way of painting the scrollbars properly: let the URLs be hosted by an AC HTML page with the poper skinning through CSS fiddling

Is that an idea Serge?

[HeDiBo]

'mol' wrote:

Just remember that it is possible to change all scrollbar elements with CSS through IE-proprietary tags. Might interfere with the painting of your own scrollbars.

Would that work in Firefox and/or Chrome too?

If the tags are proprietary for IE, I wouldn't bother. A good web design would not use proprietary IE stuff.

[HeDiBo]

'Support' wrote:

Hello Dick! Maybe you are right, I will think about that.

Thanks!

[HeDiBo]

'Support' wrote:

Hello!

You saw this demo already?

http://www.alphaskin…/webbrowser.zip

The demo depends on setting

{$DEFINE ADDWEBBROWSER} // Support of the TWebBrowser (full AC sources needed)

in sDefs.inc

But that will bring in webbrowser stuff for all projects, not only for those that need it.

So, what we really want is a TsWebBrowser component. Then only projects needing web browsing will bring in the libraries needed for that.

Thanks!

Dick

[HeDiBo]

'Support' wrote:

Hello!

I will check it soon.

I would like to skin the scroll bars of a TWebBrowser control also. Is this fixed in the latest release? Because this is already a very old issue.

[HeDiBo]

'Support' wrote:

Thank you, I will update all skins soon.

That may not be needed for the highlight problems. As you can see, the highlight in the drop down lists is OK. If the highlight in the drop down list would be the one used for the highlight in edit boxes (for all skins) only the logic of the color selection when painting the highlight needs to change, in order to use that one.

But you'll know this better. -_-

[HeDiBo]

I've made sample screenshots of both the highlight problems and the invisible selection problems. I hope this clears things up.

[attachment=6902:acHighlightProblems.jpg]

[attachment=6903:acSelectionProblems.jpg]

[HeDiBo]

The skinning works beautifully :a3:

Some minor concerns:

I noticed some problems with some skins:

• The following skins have no contrast between highlighted text and highlighted background, making the text unreadable: DarkMetro, DarkMetro_contrast, MacOS2, Matrix, Matrix_contrast, Ubuntu, Underwater, Winter2003
• The next skins have no distinction between a normal background and a highlighted background making selection disappear: Emerald, Nautilus, Nautilus_contrast, Steam, Steam2.

You can verify both in this project: [attachment=6901:acSetSysColor.zip]

Ideally the selection should look the same as the highlight in the drop down list of the combobox.

The way you place the hook may not work in all cases. The docs say that in order to be able to use WriteProcessMemory, “The handle must have PROCESS_VM_WRITE and PROCESS_VM_OPERATION access to the process”. I'm not sure that's always true. You may have to call GetSecurityInfo and SetSecurityInfo as per this msdn article.

All in all it's a great effort already :a3:

[HeDiBo]

'Support' wrote:

You can set a bigger width of popup window there (PopupWidth property).

Thanks :a3:

PS. Where are you in Ukraine? In any case: I wish you strength in these difficult times.

[HeDiBo]

'Support' wrote:

No, I'm using hooks for these functions (GetSysColor, GetSysCoorBrush and CreatePen), it's ready and in tests already.

Added the TsSkinManager.Options.ChangeSysColrs property.

Today evening or tomorrow I can give this new package for tests.

That's fantastic news :i-m_so_happy:

[HeDiBo]

'Support' wrote:

I have found a way to hook the GetSysColor procedure, I hope it helps.

If you tell us what you found, maybe we can help you :cs:

[HeDiBo]

'HeDiBo' wrote:

Now only the dark skins have subtle lines. The majority of the skins (the light ones) all have heavy lines. That was OK previously, now it's horrible,

You get more subtle lines if you make this change to acDBGrid:

Code:

Line 1363:
// Canvas.Pen.color := MixColors(SkinData.SkinManager.Palette[pcEditText], SkinData.SkinManager.Palette[pcEditBG], 0.3);
Canvas.Pen.color := MixColors(SkinData.SkinManager.Palette[pcEditText], SkinData.SkinManager.Palette[pcEditBG], 0.15);

But for lighter skins I would even prefer a 0.1 factor, where dark skins could do with the 0.3 factor.

The problem is that our eyes are not linear for differences between dark shades and light shades.

I also tried other base colors but did not find two colors that had the sought after effect for all skins.

[HeDiBo]

It has gotten worse!! 😡

Now only the dark skins have subtle lines. The majority of the skins (the light ones) all have heavy lines. That was OK previously, now it's horrible,

[HeDiBo]

Fixed in AC 9.15 :a3:

But the other changes caused a new problem in foreign languages:

[attachment=6893:acDateEdit.jpg]

As you can see, the button for current date does not fit. And going from September to October leaves a leftover from the “s” in September.

[HeDiBo]

Fixed in 9.15 :a3:

[HeDiBo]

Fixed in 9.15 :a3:

[HeDiBo]

No fix in 9.15 :huh:

[Author]

Posts