[Lasse]

Yes, my MouseDown problem is fixed but if somebody is overriding MouseUp there is still exactly same issue with it. OnMouseUp is called instead of MouseUp.

[Lasse]

This is still broken in version 13.13.

I see why. If page control's MouseDown is overrided, it is never called.

Code:

procedure MouseDown(Button: TMouseButton; Shift: TShiftState; X: Integer; Y: Integer); override;

There is now OnMouseDown called:

Code:

if Assigned(OnMouseDown) then
OnMouseDown(Self, mbLeft, GetShiftState, TCMHitTest(Message).XPos, TCMHitTest(Message).YPos);

Works, if I change that to

Code:

MouseDown(mbLeft, GetShiftState, TCMHitTest(Message).XPos, TCMHitTest(Message).YPos);

That will call the OnMouseDown

Code:

procedure TControl.MouseDown(Button: TMouseButton;
Shift: TShiftState; X, Y: Integer);
begin
if Assigned(FOnMouseDown) then FOnMouseDown(Self, Button, Shift, X, Y);
end;

Same thing with the MouseUp

Code:

procedure TControl.MouseUp(Button: TMouseButton;
Shift: TShiftState; X, Y: Integer);
begin
if Assigned(FOnMouseUp) then FOnMouseUp(Self, Button, Shift, X, Y);
end;

[Lasse]

Well, indeed. It is a wrapper for TsSkinManager and just sets some properties by overriding Create. And it seems that some of those properties is causing this. Thanks, I will investigate which one it is.

It was this

Code:

Saturation := 10;

and it does not need to be set. So, problem solved.

[Lasse]

I installed v13.00 beta and still get the AV (see attachment).

[Lasse]

I tried it even thought I already knew the answer – it did not help. I will look at the code when I have time. This is not a big issue, I just need to remember to close frames before I close Delphi.

[Lasse]

[Content was edited mistakenly by Support]

[Lasse]

I checked changes from acSBUtils.pas and I just needed to set the UnfocusedSelectionColor = clHighlight to fix this.

Code:

Colors.UnfocusedSelectionColor := clHighlight;

[Lasse]

I managed to solve this when not using extended borders mode:

Code:

procedure TBaseForm.FormCreate(Sender: TObject);
begin
inherited;

SetClassLong(Handle, GCL_HBRBACKGROUND, GetSysColorBrush(COLOR_WINDOW));
end;

[Lasse]

Thanks, atleast my problem is fixed. 🙂

[Lasse]

I have noticed similar slow down with my own editor control – basic text selection seems very sluggish. I used a sampling profiler and there seems to be a lot of FillRect32 calls in sAlphaGraph. This has not been noticeable before.

I am using SkinManager.Options.OptimizingPriority = opSpeed.

[Lasse]

Oh, I see GetExternalSkinNames has changed and is now creating objects which I need to free. Ok, that fixed this.

[Lasse]

Thanks, that is working. I did fix static border color thou.

Code:

Bmp.Canvas.Brush.Color := clBlack; // ColorToBorderColor(ColorToRGB(C));

[Lasse]

Thanks, it fixed that.

[Lasse]

I used Windows 10 skin. Unfortunately I already went back to version 10.29.

[Lasse]

You can use your demo:

1. Add new item into sTitleBar1

2. Set Align = tbaRight

3. Set Caption = This_is_a_test.pas

4. Set DropdownMenu = PopupMenu1

5. Set Style = bsMenu

[Lasse]

If FontData.UseSysFontName is False, it works. Ok, I can live with that. 🙂

[Lasse]

Ok, I will test your demo when I get home tonight. With an underscore the arrow disappears (see attachment).

[Lasse]

This seems to be fixed but there is now same problem, if the menu button is the last page.

[Lasse]

You can close this. “Enable Runtime Themes” was false in project options. I go to the corner ashamed. 🙂

[Lasse]

I created this simple demo. But guess what, it works with both XE8 and Seattle. 🙂 I will investigate why my project does not.

Code:

var
i: Integer;
LNode: PVirtualNode;
begin
VirtualDrawTree.BeginUpdate;
for i := 0 to 5 do
begin
LNode := VirtualDrawTree.AddChild(nil);
LNode.CheckType := ctCheckBox;
case i of
0: LNode.CheckState := csUncheckedNormal; // unchecked and not pressed
1: LNode.CheckState := csUncheckedPressed; // unchecked and pressed
2: LNode.CheckState := csCheckedNormal; // checked and not pressed
3: LNode.CheckState := csCheckedPressed; // checked and pressed
4: LNode.CheckState := csMixedNormal; // 3-state check box and not pressed
5: LNode.CheckState := csMixedPressed;
end;
VirtualDrawTree.AddChild(LNode); // child
end;
VirtualDrawTree.EndUpdate;
end;

[Author]

Posts