[Lasse]

I noticed the same with save dialog…

[Lasse]

Oh, there is common variable acAllowLatestCommonDialogs in sDefaults.pas. By setting that to false, dialogs are fine.

[HeDiBo]

'Lasse' wrote:

Oh, there is common variable acAllowLatestCommonDialogs in sDefaults.pas. By setting that to false, dialogs are fine.

Thanks for the info. But I do not want to change that. Even the SkinDemo program goes wrong. The variable should have been set to False in the AC distribution.

[Lasse]

Well, it is a common variable, so it can be set in your program code.

[Support]

Default value of this variable will be changed to False in the nearest release.

[Lasse]

Delphi's common variable UseLatestCommonDialogs (in Vcl.Dialogs.pas) is True by default. So, it is not so wrong now but I understand that change of behaviour is not always a good thing…

[HeDiBo]

'Support' wrote:

Default value of this variable will be changed to False in the nearest release.

Great

[HeDiBo]

'Support' wrote:

Default value of this variable will be changed to False in the nearest release.

Maybe you could make an effort to better skin the dialogs when UseLatestCommonDialogs is True.

[Support]

I'm searching ways for making it.

[HeDiBo]

'Support' wrote:

I'm searching ways for making it.

In 14.31 still no change

[HeDiBo]

Support wrote:

I’m searching ways for making it.

In 14.32 still no change 😢

[sergunalpha]

Sorry.
You should know that I’m searching a way to skin it completely latest 2-3 years.
But without success, unfortunately.

[HeDiBo]

sergunalpha wrote:

You should know that I’m searching a way to skin it completely latest 2-3 years.
But without success, unfortunately.

That’s a shame. Maybe you should not try then. Just (optionally) show the dialog in native windows style. Users would be used to that. As it is now, it is a horrible mix.

PS. As you can see above, the message quotations look very large.

• This reply was modified 6 years, 5 months ago by HeDiBo.
• This reply was modified 6 years, 5 months ago by HeDiBo.

[HeDiBo]

Apparently you’ve been working on this, because now, setting UseLatestCommonDialogs := True will totally screw up the file open dialog, making it unresponsive and throwing an exception if the dialog is cancelled. If SkinManager is not Active, it works.
Have a look at the enclosed project

Attachments:

You must be logged in to view attached files.

[Support]

Thanks for the demo.
Can you give me the Exe file also, please?
After running it on my PC dialog is not skinned after calling by both buttons (because default value of the acTryToSkinCommonDialogs is False).

[HeDiBo]

Pressing sOpenDialog shows a partly skinned dialog that will throw an exception if cancelled (same demo project) in AC 15.00.

procedure TacDialogWnd.acWndProc(var Message: TMessage);
var
  PS: TPaintStruct;
  X, Y, i: integer;
  cR, rClient: TRect;
begin
{$IFDEF LOGGED}
//  if (SkinData <> nil) and (SkinData.SkinSection <> 'DIALOG') then
    AddToLog(Message);
{$ENDIF}
  case Message.Msg of
    WM_DESTROY, WM_NCDESTROY: begin
      if SkinData.FCacheBmp <> nil then   << Access violation, because SkinData = nil!!!
        SkinData.FCacheBmp.Assign(nil);

So, please do not attempt to skin the dialog at all in this situation. The unskinned variant is what users are used to anyway.

• This reply was modified 6 years, 1 month ago by HeDiBo.

[Support]

Skinning of this dialog is disabled by default.
Compiler directives are leaved for possibility of further researching.

[HeDiBo]

Still, exceptions are not a good idea.
In the given situation, SkinData is nil and should be tested.
I’m not sure what the given compiler directives have to do with it. Or do you mean that you’re going to set it up like that?

• This reply was modified 6 years, 1 month ago by HeDiBo.

[Support]

I didn’t wrote about exceptions. I mean, that this dialog is not skinned by default (the acTryToSkinCommonDialogs variable is False in the sDefaults.pas).
Why you have this dialog skinned partially?

[HeDiBo]

Support wrote:

I didn’t wrote about exceptions. I mean, that this dialog is not skinned by default (the acTryToSkinCommonDialogs variable is False in the sDefaults.pas).
Why you have this dialog skinned partially?

No, I wrote about the exception that ocurred. I don’t know why you think that’s not a problem. If dialog should not be skinnable (the best way to go at the moment) don’t allow it or prevent exceptions.

[Author]

Posts