[JasonToms]

Hi!

I checked the 2018 new features, restore the icon classic mode（”Using of old style icons is possible. The ac_OldGlyphsMode boolean variable is declared in the sConst unit. Set this variable to True for showing of old style icons.”）, but select the directory, ADD, OK, CANCEL corresponding to the picture is still black.

By the way, why must we design to modify the source file, is not it better to design a property of skinmanager?

Looking forward to solutions.

thank you.

[attachment=8657:20180228213037.png]

[HeDiBo]

'JasonToms' wrote:

By the way, why must we design to modify the source file, is not it better to design a property of skinmanager?

I totally agree. Not every change is a good change (for some). With drastic visual changes like this, the default should be to maintain the looks it had. It must be a skinmanager setting, not a compiled setting.

[Support]

New version will have the TsSkinManager.ButtonsOptions.ModalButtonsColoring property, where is possible to colorize glyphs in [Ok], [Cancel] and some other buttons in dialogs, look screenshots.

[attachment=8660:BtnColor1.png]

[attachment=8661:BtnColor2.png]

Also, will be added coloring of glyphs in comboedits:

[attachment=8662:ColorGlyphs.png]

Changing of the ac_OldGlyphsMode variable may be placed in the project code like this:

Code:

begin
Application.Initialize;
sConst.ac_OldGlyphsMode := TRUE;
Application.MainFormOnTaskbar := True;
Application.CreateForm(TForm1, Form1);
Application.Run;
end.

It may be one-time changing for the project. I will think about a new property in the TsSkinManager for using of old glyphs.

And I'm open for other suggestions.

[HeDiBo]

'Support' wrote:

I will think about a new property in the TsSkinManager for using of old glyphs.

First of all, the variable ac_OldGlyphsMode should default to true (that's what a developer will expect: if you want a new feature, you have to specify that).

Then in sSkinManager.pas do this:

Code:

TacButtonsSupport = class(TPersistent)
private
FShowFocusRect,
FShiftContentOnClick: boolean;
public
constructor Create(AOwner: TsSkinManager);
published
property ShowFocusRect: boolean read FShowFocusRect write FShowFocusRect default True;
property ShiftContentOnClick: boolean read FShiftContentOnClick write FShiftContentOnClick default False;
property OldGlyphsMode boolean read GetOldGlyphsMode write SetOldGlyphsMode default True;
end;

In SetOldGlyphsMode, you set the ac_OldGlyphsMode variable. In GetOldGlyphsMode you retrieve it.

I think that's the simplest situation..

The property should also cover the JasonToms case. In other words, not only should the icons be colorful, they should default to the old icons.

A change to the property should result in redrawing of the combobox.

PS. I like the new look!

[JasonToms]

'Support' wrote:

New version will have the TsSkinManager.ButtonsOptions.ModalButtonsColoring property, where is possible to colorize glyphs in [Ok], [Cancel] and some other buttons in dialogs, look screenshots.

[attachment=8660:BtnColor1.png]

[attachment=8661:BtnColor2.png]

Also, will be added coloring of glyphs in comboedits:

[attachment=8662:ColorGlyphs.png]

Changing of the ac_OldGlyphsMode variable may be placed in the project code like this:

Code:

begin
Application.Initialize;
sConst.ac_OldGlyphsMode := TRUE;
Application.MainFormOnTaskbar := True;
Application.CreateForm(TForm1, Form1);
Application.Run;
end.

It may be one-time changing for the project. I will think about a new property in the TsSkinManager for using of old glyphs.

And I'm open for other suggestions.

Perfect, just what I needed…Thanks a lot..

[Author]

Posts