[Lasse]

Yeah, I use data aware components in my database administration tool (https://www.texteditor.pro/firebird/). I have made quite many optimizations for AlphaSkins to speed it up but the latest v.15.13 is remarkably slower than v.15.12 even with all the fixes I have made.

There are quite many loops which can be faster by just using variables to avoid getting items unnecessarily multiple times (it is slow). I also recommend FixInsight tool to point out bad code that we easily make in a hurry.

[Lasse]

I have tried a long time to repeat this on debug mode. No success yet. It is rare and happens on idle or after waking up from sleep mode.

[Lasse]

Both paint blocking code was added in v. 15.10. It is not old code.

[Lasse]

Btw. there is a glow issue with comboboxes in Fluent Night theme (you can see it in your demo). I fixed it by changing the GLOWMARGIN = 2 to 1.

Attachments:

You must be logged in to view attached files.

[Lasse]

I just pointed out where the problem is. It still exists in the latest version 15.10.

[Lasse]

There is also added paint locking code that is causing problems:

4214:WM_SETFOCUS, WM_KILLFOCUS: begin
      if MayBeHot(SkinData, False) and (Skindata.FOwnerControl is TWinControl) and TWinControl(Skindata.FOwnerControl).CanFocus and TWinControl(Skindata.FOwnerControl).TabStop then begin
        Skindata.BGChanged := True;
        Skindata.FFocused := WM_SETFOCUS = Message.Msg;
        // Skindata.FOwnerControl.Perform(WM_SETREDRAW, 0, 0);
        inherited acWndProc(Message);
        // Skindata.FOwnerControl.Perform(WM_SETREDRAW, 1, 0);

Commenting out that paint locking solves the problem. The question is, why these are added?

[Lasse]

In my case it is this code in acSBUtils.pas:

procedure TacEditWnd.acWndProc(var Message: TMessage);
...
4152: CM_MOUSEENTER, CM_MOUSELEAVE: begin
        Skindata.FOwnerControl.Perform(WM_SETREDRAW, 0, 0);
        inherited acWndProc(Message);
        Skindata.FOwnerControl.Perform(WM_SETREDRAW, 1, 0);
        Exit;
      end;

Commenting that out solves the problem.

[Lasse]

Something fundamental is wrong in V15.10 indeed. Control invalidate calls do not trigger repainting at all. I need to repaint controls (instantly) instead of invalidate (later).

[Lasse]

The bug seems to be in procedure TsPageControl.CheckUpDown;

I reverted the code to previous version and the ghost buttons are gone.

[Lasse]

If I comment out this line (acGlow.pas) it works in v.15.09:

765: // CheckOverlappedRects;

• This reply was modified 5 years, 8 months ago by Lasse.

[Lasse]

I will debug the v.15.09 code later when I have time.

[Lasse]

If you take a look at any ChangeScale procedure in Vcl (TControl, TWinControl, etc.), all of them are using MulDiv.

[Lasse]

Yes, 1320 div 96 = 13.

[Lasse]

This happens easily, if the skin is modified because the preview image is not extracted. See: http://www.alphaskins.com/forum/?topic=about-alphaskins-editor

I have fixed this issue by creating the preview image by myself.

• This reply was modified 5 years, 11 months ago by Lasse.

[Lasse]

I removed that ExcludeClipRect code and seems to work…

procedure TsPageControl.AcPaint(const Message: TWMPaint);
...
        if DropBtn <> nil then
          with DropBtn.BoundsRect do
            ExcludeClipRect(DC, Left, Top, Right, Bottom);

[Lasse]

A tip: https://icomoon.io/app/#/select

I found this web application very useful to create own OTFs from selected or imported icons. So, I don’t need to load huge amount of unused icons for the application.

[Lasse]

Also I noticed in sCommonData.pas unit and function ScaleInt those Value * PPI div 96 should be MulDiv(Value, PPI, 96).

For example 11 * 120 div 96 = 13 but MulDiv(11, 120, 96) = 14.

[Lasse]

Another scaling issue in TsComboBox

Attachments:

You must be logged in to view attached files.

[Lasse]

It is ok now.

• This reply was modified 6 years ago by Lasse.

[Lasse]

But after I edit the skin in AlphaSkins Editor, it drops the preview image. File size seems to drop from 65KB to 56KB, if I just unpack and open the skin and then save it. And I see that the preview image AT134.PNG is not in the directory where I unpack the skin. Works after I added that file by myself.

• This reply was modified 6 years ago by Lasse.
• This reply was modified 6 years ago by Lasse.

[Author]

Posts