AC15.04 Scaling issue

This topic has 8 replies, 4 voices, and was last updated 5 years, 11 months ago by Support.

Viewing 8 posts - 1 through 8 (of 8 total)

Author

Posts
March 9, 2020 at 1:17 am #68576
sergunalpha
Keymaster
This issue will be solved in the nearest release.
March 21, 2020 at 5:43 pm #68592
Lasse
Participant
Another scaling issue in TsComboBox

Attachments:
You must be logged in to view attached files.
March 21, 2020 at 5:47 pm #68594
Lasse
Participant
Also I noticed in sCommonData.pas unit and function ScaleInt those Value * PPI div 96 should be MulDiv(Value, PPI, 96).

For example 11 * 120 div 96 = 13 but MulDiv(11, 120, 96) = 14.
March 25, 2020 at 11:18 pm #68611
Support
Keymaster
Interesting. Why 14? Correct value is 13?
I didn’t knew about a difference between these two ways. I will research it and the issue with ComboBox scaling too.
March 26, 2020 at 1:13 am #68618
Stephane Senecal
Participant
11 * 120 = 1320
1320 / 96 = 13.75
Round(13.75) = 14

Stephane Senecal
CIS Group
Delphi programmer since 2001
March 28, 2020 at 1:11 pm #68634
Lasse
Participant
Yes, 1320 div 96 = 13.
March 28, 2020 at 7:44 pm #68635
Lasse
Participant
If you take a look at any ChangeScale procedure in Vcl (TControl, TWinControl, etc.), all of them are using MulDiv.
March 29, 2020 at 7:58 am #68642
Support
Keymaster
Interesting. It means that MulDiv works using a floating point calculations (slower).
I will think where to use it instead of “*” and “div”.
Author

Posts

Viewing 8 posts - 1 through 8 (of 8 total)

You must be logged in to reply to this topic.